Add mixin accessor.

Add mixin accessor.

R=ahe@google.com, rmacnak@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28661

[gbracha, 2013-10-14 23:44:34]

I don't remember that we ever decided this, but it is an important part of the
model.

[rmacnak, 2013-10-14 23:52:24]

lgtm

[ahe, 2013-10-15 06:59:34]

lgtm

[ahe, 2013-10-15 07:00:37]

Suggestion. I think it is clearer.

https://codereview.chromium.org/27261003/diff/1/sdk/lib/mirrors/mirrors.dart
File sdk/lib/mirrors/mirrors.dart (right):

https://codereview.chromium.org/27261003/diff/1/sdk/lib/mirrors/mirrors.dart#...
sdk/lib/mirrors/mirrors.dart:770: * Otherwise returns a class mirror on
[reflectee].
Otherwise returns this.

[gbracha, 2013-10-15 17:00:57]

Committed patchset #1 manually as r28661 (presubmit successful).

[gbracha, 2013-10-15 17:03:21]

https://codereview.chromium.org/27261003/diff/1/sdk/lib/mirrors/mirrors.dart
File sdk/lib/mirrors/mirrors.dart (right):

https://codereview.chromium.org/27261003/diff/1/sdk/lib/mirrors/mirrors.dart#...
sdk/lib/mirrors/mirrors.dart:770: * Otherwise returns a class mirror on
[reflectee].
On 2013/10/15 07:00:38, ahe wrote:
> Otherwise returns this.


That is a stronger specification. In principle, you could return a different
instance of ClassMirror. I deliberately left that open to the implementation.

[ahe, 2013-10-16 07:28:39]

https://codereview.chromium.org/27261003/diff/1/sdk/lib/mirrors/mirrors.dart
File sdk/lib/mirrors/mirrors.dart (right):

https://codereview.chromium.org/27261003/diff/1/sdk/lib/mirrors/mirrors.dart#...
sdk/lib/mirrors/mirrors.dart:770: * Otherwise returns a class mirror on
[reflectee].
On 2013/10/15 17:03:21, gbracha wrote:
> On 2013/10/15 07:00:38, ahe wrote:
> > Otherwise returns this.
> 
> 
> That is a stronger specification. In principle, you could return a different
> instance of ClassMirror. I deliberately left that open to the implementation.

Returning "this" is more accurate in case of subclasses of ClassMirror. This
might be a hypothetical point, as I think all subclasses of ClassMirrors are
going away. It also makes it clear what should happen if you have an original
declaration versus an instantiated type.

However, both these points apply to the class mirror on M as well. But they also
apply to [superclass] and [superinterfaces] above.

Can we somehow clarify this?

[gbracha, 2013-10-16 18:16:13]

On 2013/10/16 07:28:39, ahe wrote:
> https://codereview.chromium.org/27261003/diff/1/sdk/lib/mirrors/mirrors.dart
> File sdk/lib/mirrors/mirrors.dart (right):
> 
>
https://codereview.chromium.org/27261003/diff/1/sdk/lib/mirrors/mirrors.dart#...
> sdk/lib/mirrors/mirrors.dart:770: * Otherwise returns a class mirror on
> [reflectee].
> On 2013/10/15 17:03:21, gbracha wrote:
> > On 2013/10/15 07:00:38, ahe wrote:
> > > Otherwise returns this.
> > 
> > 
> > That is a stronger specification. In principle, you could return a different
> > instance of ClassMirror. I deliberately left that open to the
implementation.
> 
> Returning "this" is more accurate in case of subclasses of ClassMirror. This
> might be a hypothetical point, as I think all subclasses of ClassMirrors are
> going away. It also makes it clear what should happen if you have an original
> declaration versus an instantiated type.
> 
> However, both these points apply to the class mirror on M as well. But they
also
> apply to [superclass] and [superinterfaces] above.
> 
> Can we somehow clarify this?

Let's discuss tomorrow, as I'm not sure I understand the concern.