Issue 27251003: Generate onlyForRti class constructor for csp.

LGTM! https://codereview.chromium.org/27251003/diff/1/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart File sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart (right): https://codereview.chromium.org/27251003/diff/1/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart#newcode264 sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart:264: if (classElement.isMixinApplication) return; Combine the two checks?

7 years, 2 months ago (2013-10-16 08:23:51 UTC) #2

Johnni Winther

https://codereview.chromium.org/27251003/diff/1/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart File sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart (right): https://codereview.chromium.org/27251003/diff/1/sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart#newcode264 sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart:264: if (classElement.isMixinApplication) return; On 2013/10/16 08:23:51, kasperl wrote: > ...

7 years, 2 months ago (2013-10-16 08:30:10 UTC) #3

Johnni Winther

7 years, 2 months ago (2013-10-16 08:31:28 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r28710 (presubmit successful).

Expand Messages | Collapse Messages

Issue 27251003: Generate onlyForRti class constructor for csp. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Updated cf. comment #

Messages