Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 27247002: Formatter library entry-point for the masses (w/ gypi update). (Closed)

Created:
7 years, 2 months ago by pquitslund
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Formatter library entry-point for the masses (w/ gypi update). (Note the manual change in resource_sources.gypi. I verified that this works locally.) R=jmesserly@google.com, johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=28613

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
A + pkg/analyzer_experimental/lib/formatter.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D pkg/analyzer_experimental/lib/src/services/formatter.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/bin/resources_sources.gypi View 1 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
pquitslund
7 years, 2 months ago (2013-10-14 21:40:10 UTC) #1
Jennifer Messerly
lgtm
7 years, 2 months ago (2013-10-14 21:41:43 UTC) #2
Cutch
lgtm
7 years, 2 months ago (2013-10-14 21:42:54 UTC) #3
pquitslund
7 years, 2 months ago (2013-10-14 21:46:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r28613 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698