Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 27246006: Small fix to boot.js so it can work with CSP if an existing html-import tag is (Closed)

Created:
7 years, 2 months ago by Siggi Cherem (dart-lang)
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Small fix to boot.js so it can work with CSP if an existing html-import tag is present. Note: this will be deleted soon when we deprecate boot.js (a week or so). R=jmesserly@google.com, sergeygs@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=28675

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M pkg/polymer/lib/boot.js View 1 chunk +16 lines, -1 line 2 comments Download

Messages

Total messages: 5 (0 generated)
Siggi Cherem (dart-lang)
7 years, 2 months ago (2013-10-15 17:23:10 UTC) #1
Jennifer Messerly
lgtm with one error message tweak :) https://codereview.chromium.org/27246006/diff/1/pkg/polymer/lib/boot.js File pkg/polymer/lib/boot.js (right): https://codereview.chromium.org/27246006/diff/1/pkg/polymer/lib/boot.js#newcode83 pkg/polymer/lib/boot.js:83: "polyfill.\nIf you ...
7 years, 2 months ago (2013-10-15 17:59:21 UTC) #2
sergeygs
On 2013/10/15 17:59:21, John Messerly wrote: > lgtm with one error message tweak :) > ...
7 years, 2 months ago (2013-10-15 18:13:46 UTC) #3
Siggi Cherem (dart-lang)
thx https://codereview.chromium.org/27246006/diff/1/pkg/polymer/lib/boot.js File pkg/polymer/lib/boot.js (right): https://codereview.chromium.org/27246006/diff/1/pkg/polymer/lib/boot.js#newcode83 pkg/polymer/lib/boot.js:83: "polyfill.\nIf you are running a Chrome packaged app, ...
7 years, 2 months ago (2013-10-15 19:10:44 UTC) #4
Siggi Cherem (dart-lang)
7 years, 2 months ago (2013-10-15 19:11:10 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r28675 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698