Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 27240004: Making all callbacks use zones (take 2) (Closed)

Created:
7 years, 2 months ago by blois
Modified:
7 years, 2 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Making all callbacks use zones (take 2) Changes: fixed parameter ordering for RTCPeerConnection.getStats and fixed error for StorageInfo. Revert "Revert "Making all callbacks use zones"" BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=28674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -63 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 12 chunks +63 lines, -18 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 14 chunks +75 lines, -22 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 5 chunks +12 lines, -6 lines 0 comments Download
M tools/dom/src/EventStreamProvider.dart View 1 chunk +0 lines, -6 lines 0 comments Download
A tools/dom/src/shared_html.dart View 1 chunk +14 lines, -0 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 3 chunks +2 lines, -4 lines 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 3 chunks +2 lines, -5 lines 0 comments Download
M tools/dom/templates/html/impl/impl_MutationObserver.darttemplate View 1 chunk +4 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_RTCPeerConnection.darttemplate View 1 chunk +7 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Window.darttemplate View 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 2 months ago (2013-10-15 18:00:04 UTC) #1
Emily Fortuna
lgtm
7 years, 2 months ago (2013-10-15 18:30:59 UTC) #2
blois
7 years, 2 months ago (2013-10-15 19:07:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28674 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698