Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 27227002: Untyping List types (Closed)

Created:
7 years, 2 months ago by blois
Modified:
7 years, 2 months ago
Reviewers:
vsm, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Untyping List types Making all DOM lists implement List rather than List<T>. This is primarily for NodeList which is used in cases where it's just a list of Elements and allows us to assign it to List<Element> without type checks. BUG= R=sra@google.com, vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=28597

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -55 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 20 chunks +20 lines, -20 lines 2 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 20 chunks +20 lines, -20 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
blois
7 years, 2 months ago (2013-10-14 18:00:45 UTC) #1
vsm
lgtm https://codereview.chromium.org/27227002/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/27227002/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode8012 sdk/lib/html/dart2js/html_dart2js.dart:8012: +class DomStringList extends Interceptor with ListMixin<String>, ImmutableListMixin<String> implements ...
7 years, 2 months ago (2013-10-14 18:10:47 UTC) #2
sra1
lgtm
7 years, 2 months ago (2013-10-14 18:15:27 UTC) #3
blois
https://codereview.chromium.org/27227002/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/27227002/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode8012 sdk/lib/html/dart2js/html_dart2js.dart:8012: +class DomStringList extends Interceptor with ListMixin<String>, ImmutableListMixin<String> implements JavaScriptIndexingBehavior, ...
7 years, 2 months ago (2013-10-14 18:31:02 UTC) #4
blois
7 years, 2 months ago (2013-10-14 18:37:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r28597 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698