Allow access to context variables in optimized/inlined frames.

Allow access to context variables in optimized/inlined frames.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28669

[siva, 2013-10-15 17:39:12]

lgtm

https://chromiumcodereview.appspot.com/27226004/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://chromiumcodereview.appspot.com/27226004/diff/1/runtime/vm/debugger.cc...
runtime/vm/debugger.cc:1046: ASSERT((callee_activation != NULL) ||
!entry_ctx.IsNull());
The two asserts seem hard to read together, I am wondering if this combo makes
it easier:

ASSERT(((callee_activation != NULL) && entry_ctx.IsNull()) ||
       ((callee_activation == NULL) && !entry_ctx.IsNull()));

[turnidge, 2013-10-15 18:07:28]

https://chromiumcodereview.appspot.com/27226004/diff/1/runtime/vm/debugger.cc
File runtime/vm/debugger.cc (right):

https://chromiumcodereview.appspot.com/27226004/diff/1/runtime/vm/debugger.cc...
runtime/vm/debugger.cc:1046: ASSERT((callee_activation != NULL) ||
!entry_ctx.IsNull());
On 2013/10/15 17:39:12, siva wrote:
> The two asserts seem hard to read together, I am wondering if this combo makes
> it easier:
> 
> ASSERT(((callee_activation != NULL) && entry_ctx.IsNull()) ||
>        ((callee_activation == NULL) && !entry_ctx.IsNull()));

Done.

[turnidge, 2013-10-15 18:17:41]

Committed patchset #4 manually as r28669 (presubmit successful).