Do not hide membership of implementation classes in dart:core.

Do not hide membership of implementation classes in dart:core.

BUG=http://dartbuc.com/12141
R=ahe@google.com, asiva@google.com, gbracha@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28695

[rmacnak, 2013-10-14 21:18:03]

https://codereview.chromium.org/27226003/diff/8001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (left):

https://codereview.chromium.org/27226003/diff/8001/runtime/lib/mirrors.cc#old...
runtime/lib/mirrors.cc:1124: !RawObject::IsImplementationClassId(klass.id())) {
We originally filtered these out because we were using UserVisibleName as the
key for classes. In the version of mirrors that used the embedding API,
superclasses and interfaces were looked up by name rather than by reference, and
we got into problems where, say, OneByteString would be added to the core
library's members after String and replace it in the map and produce incorrect
results. Now that we are properly looking for superclasses, interfaces, etc by
reference and we aren't using UserVisibleName, we can correctly admit to the
membership of these classes.

[gbracha, 2013-10-14 21:20:26]

tests lgtm

[ahe, 2013-10-15 07:14:01]

Tests LGTM!

https://codereview.chromium.org/27226003/diff/8001/tests/lib/mirrors/hierarch...
File tests/lib/mirrors/hierarchy_invariants_test.dart (right):

https://codereview.chromium.org/27226003/diff/8001/tests/lib/mirrors/hierarch...
tests/lib/mirrors/hierarchy_invariants_test.dart:11:
isAnonymousMixinApplication(classMirror) {
Should we have an accessor for this in the API?

[siva, 2013-10-15 23:52:17]

lgtm

[rmacnak, 2013-10-16 00:15:18]

Committed patchset #4 manually as r28695 (presubmit successful).