Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 27226002: Add back native tracing to optimized code. Tracing natives is an important part of perfromance anal… (Closed)

Created:
7 years, 2 months ago by srdjan
Modified:
7 years, 2 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add back native tracing to optimized code. Tracing natives is an important part of perfromance analysis and should therefore be available in optiumized VM as well. No performance implications are expected. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=28614

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M runtime/vm/native_arguments.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
7 years, 2 months ago (2013-10-14 17:57:55 UTC) #1
siva
lgtm
7 years, 2 months ago (2013-10-14 21:21:13 UTC) #2
srdjan
7 years, 2 months ago (2013-10-14 21:47:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28614.

Powered by Google App Engine
This is Rietveld 408576698