Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 27225003: Give dart2js partial coverage from the initializing formals test. (Mostly their types.) (Closed)

Created:
7 years, 2 months ago by rmacnak
Modified:
7 years, 2 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Give dart2js partial coverage from the initializing formals test. (Mostly their types.) BUG=http://dartbug.com/11281 R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=28656

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -46 lines) Patch
M tests/lib/lib.status View 1 chunk +3 lines, -1 line 0 comments Download
M tests/lib/mirrors/initializing_formals_test.dart View 6 chunks +45 lines, -45 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmacnak
7 years, 2 months ago (2013-10-14 18:36:40 UTC) #1
ahe
LGTM, thank you!
7 years, 2 months ago (2013-10-15 07:01:22 UTC) #2
rmacnak
7 years, 2 months ago (2013-10-15 16:40:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28656 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698