Implement new mixin application syntax

Implement new mixin application syntax

Implment the class X = S with M syntax, add warning on deprecated
typedef syntax. Also convert a handful of tests. More tests to
be converted subsequently.

R=regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28652

[hausner, 2013-10-14 23:31:49]

Testing dart2js et al in progress

[regis, 2013-10-15 00:19:41]

LGTM

Most if not all comments are unrelated to your cl, but maybe it is a good time
to cleanup after me :-)

https://codereview.chromium.org/27223005/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/27223005/diff/1/runtime/vm/parser.cc#newcode3842
runtime/vm/parser.cc:3842: cls.set_is_synthesized_class();
I am wondering if this synthesized class marker is necessary.

https://codereview.chromium.org/27223005/diff/1/runtime/vm/parser.cc#newcode3853
runtime/vm/parser.cc:3853: // because of issues involving subsitution of type
parameters
This is not a TODO. The issue 12773 is marked as fixed.
We do treat a mixin application as an alias, although it is implemented as a
subclass. The implementation will not change and is hidden from the user.

https://codereview.chromium.org/27223005/diff/1/runtime/vm/parser.cc#newcode3859
runtime/vm/parser.cc:3859: // present.
This comment is actually not correct anymore. The interface is added later at
class finalization.

https://codereview.chromium.org/27223005/diff/1/runtime/vm/parser.cc#newcode4060
runtime/vm/parser.cc:4060: // of issues involving subsitution of type parameters
ditto, although this ParseMixinTypedef will be removed soon.

[hausner, 2013-10-15 15:57:06]

https://codereview.chromium.org/27223005/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/27223005/diff/1/runtime/vm/parser.cc#newcode3842
runtime/vm/parser.cc:3842: cls.set_is_synthesized_class();
On 2013/10/15 00:19:41, regis wrote:
> I am wondering if this synthesized class marker is necessary.

I can look at this for a separate change. The debugger might be able to take
advantage of this flag.

https://codereview.chromium.org/27223005/diff/1/runtime/vm/parser.cc#newcode3853
runtime/vm/parser.cc:3853: // because of issues involving subsitution of type
parameters
On 2013/10/15 00:19:41, regis wrote:
> This is not a TODO. The issue 12773 is marked as fixed.
> We do treat a mixin application as an alias, although it is implemented as a
> subclass. The implementation will not change and is hidden from the user.

Done.

https://codereview.chromium.org/27223005/diff/1/runtime/vm/parser.cc#newcode3859
runtime/vm/parser.cc:3859: // present.
On 2013/10/15 00:19:41, regis wrote:
> This comment is actually not correct anymore. The interface is added later at
> class finalization.

Done.

https://codereview.chromium.org/27223005/diff/1/runtime/vm/parser.cc#newcode4060
runtime/vm/parser.cc:4060: // of issues involving subsitution of type parameters
On 2013/10/15 00:19:41, regis wrote:
> ditto, although this ParseMixinTypedef will be removed soon.

Done.

[hausner, 2013-10-15 16:13:11]

Committed patchset #2 manually as r28652 (presubmit successful).