Issue 27223003: Deprecate query and queryAll, also add back querySelector and querySelectorAll.

Issue 27223003: Deprecate query and queryAll, also add back querySelector and querySelectorAll. (Closed)

Created:
7 years, 2 months ago by Emily Fortuna

Modified:
7 years, 2 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org, blois

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Deprecate query and queryAll, also add back querySelector and querySelectorAll. BUG= R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=28699

Patch Set 1 : #

Total comments: 2

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+387 lines, -148 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	9 chunks	+123 lines, -49 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	11 chunks	+127 lines, -50 lines	2 comments	Download
M	tools/dom/docs/docs.json	View	2 chunks	+31 lines, -30 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	tools/dom/src/dartium_Platform.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/dart2js/html_dart2js.darttemplate	View	1 chunk	+16 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View	1 chunk	+16 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Document.darttemplate	View	1 chunk	+23 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_DocumentFragment.darttemplate	View	2 chunks	+24 lines, -3 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1 chunk	+22 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_HTMLSelectElement.darttemplate	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_HTMLTemplateElement.darttemplate	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

First stage of fix for https://code.google.com/p/dart/issues/detail?id=13357 https://code.google.com/p/dart/issues/detail?id=14015

7 years, 2 months ago (2013-10-14 18:27:11 UTC) #1

Jacob

lgtm https://codereview.chromium.org/27223003/diff/3001/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (right): https://codereview.chromium.org/27223003/diff/3001/sdk/lib/html/dartium/html_dartium.dart#newcode26648 sdk/lib/html/dartium/html_dartium.dart:26648: + if ((blob_OR_source_OR_stream is _WebKitMediaSource || blob_OR_source_OR_stream == ...

7 years, 2 months ago (2013-10-15 22:27:47 UTC) #3

Emily Fortuna

https://codereview.chromium.org/27223003/diff/3001/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (right): https://codereview.chromium.org/27223003/diff/3001/sdk/lib/html/dartium/html_dartium.dart#newcode26648 sdk/lib/html/dartium/html_dartium.dart:26648: + if ((blob_OR_source_OR_stream is _WebKitMediaSource || blob_OR_source_OR_stream == null)) ...

7 years, 2 months ago (2013-10-15 22:41:28 UTC) #4

Emily Fortuna

7 years, 2 months ago (2013-10-16 00:45:06 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r28699 (presubmit successful).

Expand Messages | Collapse Messages