Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 272003003: Don't run the testing script on debian (Closed)

Created:
6 years, 7 months ago by ricow1
Modified:
6 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't run the testing script on debian We currently can't execute it since the checked in binaries are compiled on precise machines. I have filed http://dartbug.com/18742 to track us updating it R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=35963

Patch Set 1 #

Patch Set 2 : Import dart:collection instead of dart:html to make us able to run the standalone vm on the test file #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M tools/bots/linux_distribution_support.py View 1 2 chunks +7 lines, -3 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
6 years, 7 months ago (2014-05-09 07:57:53 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/272003003/diff/20001/tools/bots/linux_distribution_support.py File tools/bots/linux_distribution_support.py (right): https://codereview.chromium.org/272003003/diff/20001/tools/bots/linux_distribution_support.py#newcode155 tools/bots/linux_distribution_support.py:155: if (build_info.builder_tag == 'ubuntu_precise'): Could a temporary hack ...
6 years, 7 months ago (2014-05-09 08:42:06 UTC) #2
ricow1
https://codereview.chromium.org/272003003/diff/20001/tools/bots/linux_distribution_support.py File tools/bots/linux_distribution_support.py (right): https://codereview.chromium.org/272003003/diff/20001/tools/bots/linux_distribution_support.py#newcode155 tools/bots/linux_distribution_support.py:155: if (build_info.builder_tag == 'ubuntu_precise'): On 2014/05/09 08:42:06, Søren Gjesse ...
6 years, 7 months ago (2014-05-09 09:08:46 UTC) #3
ricow1
6 years, 7 months ago (2014-05-09 09:09:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r35963 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698