Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 271893002: Add trace_service_pause_events flag and related tracing (Closed)

Created:
6 years, 7 months ago by Cutch
Modified:
6 years, 7 months ago
Reviewers:
turnidge, keertip
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add trace_service_pause_events flag and paused at exit tracing R=keertip@google.com, turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=35944

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M runtime/bin/vmservice/server.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/message_handler.cc View 1 2 3 2 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/service.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/standalone/vmservice/test_helper.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Cutch
6 years, 7 months ago (2014-05-08 15:29:33 UTC) #1
turnidge
lgtm
6 years, 7 months ago (2014-05-08 17:10:05 UTC) #2
keertip
https://codereview.chromium.org/271893002/diff/20001/runtime/vm/message_handler.cc File runtime/vm/message_handler.cc (right): https://codereview.chromium.org/271893002/diff/20001/runtime/vm/message_handler.cc#newcode235 runtime/vm/message_handler.cc:235: OS::PrintErr("Isolate %s paused before exiting.\n", name()); Would it be ...
6 years, 7 months ago (2014-05-08 17:18:12 UTC) #3
Cutch
https://codereview.chromium.org/271893002/diff/20001/runtime/vm/message_handler.cc File runtime/vm/message_handler.cc (right): https://codereview.chromium.org/271893002/diff/20001/runtime/vm/message_handler.cc#newcode235 runtime/vm/message_handler.cc:235: OS::PrintErr("Isolate %s paused before exiting.\n", name()); On 2014/05/08 17:18:12, ...
6 years, 7 months ago (2014-05-08 21:54:54 UTC) #4
keertip
lgtm
6 years, 7 months ago (2014-05-08 22:02:33 UTC) #5
Cutch
6 years, 7 months ago (2014-05-08 22:02:52 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 manually as r35944 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698