Issue 27179004: Issue 12103. It is warning to provide wrong number of type arguments for list/map literals.

Issue 27179004: Issue 12103. It is warning to provide wrong number of type arguments for list/map literals. (Closed)

Created:
7 years, 2 months ago by scheglov

Modified:
7 years, 2 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org, lukeechurch_gmail.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 12103. It is warning to provide wrong number of type arguments for list/map literals. https://code.google.com/p/dart/issues/detail?id=12103 R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=28588

Patch Set 2 : Extract check into method. #

Total comments: 2

Patch Set 3 : Non-error tests. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+126 lines, -50 lines)			Patch
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/StaticTypeWarningCode.java	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java	View	1	4 chunks	+53 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/Parser.java	View		2 chunks	+0 lines, -15 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/parser/ParserErrorCode.java	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/parser/ErrorParserTest.java	View		3 chunks	+0 lines, -26 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/NonErrorResolverTest.java	View	1 2	1 chunk	+20 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java	View		1 chunk	+30 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer.status	View		2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/27179004/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java (right): https://codereview.chromium.org/27179004/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java#newcode740 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:740: // XXX Remove comment https://codereview.chromium.org/27179004/diff/4001/editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java File editor/tools/plugins/com.google.dart.engine_test/src/com/google/dart/engine/resolver/StaticTypeWarningCodeTest.java (right): ...

7 years, 2 months ago (2013-10-14 16:20:57 UTC) #2

jwren

LGTM, but it isn't clear looking at the tests why more tests are passing now ...

7 years, 2 months ago (2013-10-14 16:23:25 UTC) #3

scheglov

@Jaime: when we moved these error codes, they become warnings instead of errors. https://codereview.chromium.org/27179004/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java File ...

7 years, 2 months ago (2013-10-14 16:30:40 UTC) #4

scheglov

7 years, 2 months ago (2013-10-14 16:31:28 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r28588 (presubmit successful).

Expand Messages | Collapse Messages