Indicate test will get a static warning when running the analyzer on it.

Indicate test will get a static warning when running the analyzer on it.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35929

[Brian Wilkerson, 2014-05-08 14:23:35]

LGTM, thanks!

[Brian Wilkerson, 2014-05-08 17:49:57]

LGTM, unless you didn't intend to add a new test.

https://codereview.chromium.org/271653007/diff/1/tests/language/error_stacktr...
File tests/language/error_stacktrace_test.dart (right):

https://codereview.chromium.org/271653007/diff/1/tests/language/error_stacktr...
tests/language/error_stacktrace_test.dart:89: var trace = e.stackTrace; /// 01:
static type warning
As I understand it, this means that there will be another test added that didn't
exist before (language/error_stacktrace_test/NONE) that will be missing this
line. I'm not sure what value it adds and I'm not sure whether that's what you
intended here. (I think you can avoid adding the extra test by dropping the
"01:", but I'm not sure.)

[siva, 2014-05-08 18:26:25]

https://codereview.chromium.org/271653007/diff/1/tests/language/error_stacktr...
File tests/language/error_stacktrace_test.dart (right):

https://codereview.chromium.org/271653007/diff/1/tests/language/error_stacktr...
tests/language/error_stacktrace_test.dart:89: var trace = e.stackTrace; /// 01:
static type warning
Removed 01.

On 2014/05/08 17:49:58, Brian Wilkerson wrote:
> As I understand it, this means that there will be another test added that
didn't
> exist before (language/error_stacktrace_test/NONE) that will be missing this
> line. I'm not sure what value it adds and I'm not sure whether that's what you
> intended here. (I think you can avoid adding the extra test by dropping the
> "01:", but I'm not sure.)

[siva, 2014-05-08 18:29:21]

Removed the status file changes that I was using for some test purposes.

[siva, 2014-05-08 18:30:27]

Committed patchset #3 manually as r35929 (presubmit successful).