Issue 271183002: Modernize the docs for args.

Issue 271183002: Modernize the docs for args. (Closed)

Created:
6 years, 7 months ago by Bob Nystrom

Modified:
6 years, 7 months ago

Reviewers:
nweiz, kevmoo

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Modernize the docs for args. R=kevmoo@google.com Committed: https://code.google.com/p/dart/source/detail?r=36072

Patch Set 1 #

Total comments: 6

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+361 lines, -425 lines)			Patch
A	pkg/args/README.md	View	1 chunk	+256 lines, -0 lines	4 comments	Download
M	pkg/args/example/test_runner.dart	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	pkg/args/lib/args.dart	View	7 chunks	+46 lines, -335 lines	0 comments	Download
M	pkg/args/lib/src/options.dart	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	pkg/args/lib/src/parser.dart	View	7 chunks	+27 lines, -43 lines	2 comments	Download
M	pkg/args/lib/src/usage.dart	View	2 chunks	+27 lines, -37 lines	0 comments	Download
M	pkg/args/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

nweiz

https://codereview.chromium.org/271183002/diff/1/pkg/args/README.md File pkg/args/README.md (right): https://codereview.chromium.org/271183002/diff/1/pkg/args/README.md#newcode1 pkg/args/README.md:1: Empty line. https://codereview.chromium.org/271183002/diff/1/pkg/args/README.md#newcode11 pkg/args/README.md:11: import 'package:args/args.dart'; I think at ...

6 years, 7 months ago (2014-05-12 20:15:29 UTC) #4

Bob Nystrom

Committed patchset #1 manually as r36072 (presubmit successful).

6 years, 7 months ago (2014-05-12 21:28:56 UTC) #5

Bob Nystrom

6 years, 7 months ago (2014-05-12 21:29:26 UTC) #6

Message was sent while issue was closed.

Thanks!

https://codereview.chromium.org/271183002/diff/1/pkg/args/README.md
File pkg/args/README.md (right):

https://codereview.chromium.org/271183002/diff/1/pkg/args/README.md#newcode1
pkg/args/README.md:1: 
On 2014/05/12 20:15:30, nweiz wrote:
> Empty line.

Done.

https://codereview.chromium.org/271183002/diff/1/pkg/args/README.md#newcode11
pkg/args/README.md:11: import 'package:args/args.dart';
On 2014/05/12 20:15:30, nweiz wrote:
> I think at this point installation instructions produce more clutter than
> benefit.

Done.

https://codereview.chromium.org/271183002/diff/1/pkg/args/lib/src/parser.dart
File pkg/args/lib/src/parser.dart (right):

https://codereview.chromium.org/271183002/diff/1/pkg/args/lib/src/parser.dart...
pkg/args/lib/src/parser.dart:13: /// The actual parsing class. Unlike
[ArgParser] which is really more an "arg
On 2014/05/12 20:15:30, nweiz wrote:
> It would be nice to convert this to use single-sentence first paragraphs while
> you're in here.

Done.

Expand Messages | Collapse Messages