Issue 270993002: Added error handling and a better error message if we fail to write output in docgen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 270993002: Added error handling and a better error message if we fail to write output in docgen. (Closed)

Created:
6 years, 7 months ago by Emily Fortuna

Modified:
6 years, 7 months ago

Reviewers:
Alan Knight, kevmoo

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Added error handling and a better error message if we fail to write output in docgen. BUG= R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=35984

Patch Set 3 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
	M	pkg/docgen/lib/src/generator.dart	View	1	1 chunk	+9 lines, -2 lines	0 comments	Download
	M	pkg/docgen/lib/src/viewer.dart	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Fix for: https://code.google.com/p/dart/issues/detail?id=18125

6 years, 7 months ago (2014-05-09 00:20:27 UTC) #1

kevmoo

DBC https://codereview.chromium.org/270993002/diff/1/pkg/docgen/lib/src/generator.dart File pkg/docgen/lib/src/generator.dart (right): https://codereview.chromium.org/270993002/diff/1/pkg/docgen/lib/src/generator.dart#newcode144 pkg/docgen/lib/src/generator.dart:144: 'permissions to that directory? If not, please specifi ...

6 years, 7 months ago (2014-05-09 00:24:02 UTC) #2

Emily Fortuna

6 years, 7 months ago (2014-05-09 17:28:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r35984 (presubmit successful).

Expand Messages | Collapse Messages

Issue 270993002: Added error handling and a better error message if we fail to write output in docgen. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages