pkg/unittest: remove deprecated features

pkg/unittest: remove deprecated features

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35954

[kevmoo, 2014-05-08 23:32:06]

Here's the big cleanup.

Note: the two tweaks made to the angular code base are already in their core
repo.

Instead of waiting for a full refresh from them, I selectively updated our copy
to ensure bots stay green.

[Siggi Cherem (dart-lang), 2014-05-09 00:44:14]

On 2014/05/08 23:32:06, kevmoo wrote:
> Here's the big cleanup.
> 
> Note: the two tweaks made to the angular code base are already in their core
> repo.
> 
> Instead of waiting for a full refresh from them, I selectively updated our
copy
> to ensure bots stay green.

overall looks good. Even though the angular changes have also been done
externally, we normally keep third_party/pkg/angular matching an external
revision without any local patches. Any chance we could do that instead?
(calling 'update_angular.sh' in third_party/pkg/)?

[Siggi Cherem (dart-lang), 2014-05-09 00:51:33]

On 2014/05/09 00:44:14, Siggi Cherem (dart-lang) wrote:
> On 2014/05/08 23:32:06, kevmoo wrote:
> > Here's the big cleanup.
> > 
> > Note: the two tweaks made to the angular code base are already in their core
> > repo.
> > 
> > Instead of waiting for a full refresh from them, I selectively updated our
> copy
> > to ensure bots stay green.
> 
> overall looks good. Even though the angular changes have also been done
> externally, we normally keep third_party/pkg/angular matching an external
> revision without any local patches. Any chance we could do that instead?
> (calling 'update_angular.sh' in third_party/pkg/)?

we talked about it some more offline, I think this is OK given that the change
is already in their repo, and patching it is totally better than marking tests
as Skip or Fail.

lgtm

[kevmoo, 2014-05-09 00:59:07]

Committed patchset #1 manually as r35954 (presubmit successful).