Making all callbacks use zones

Making all callbacks use zones

This was primarily converting APIs to use Futures, all appear to be new ones since we did the last pass.

MutationObserver and Window.requestAnimationFrame had to be fixed manually.

BUG=
R=efortuna@google.com, floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28607

[floitsch, 2013-10-12 12:45:14]

Thanks.
LGTM (but I'm not familiar enough with the code, so wait for Emily).

Do we also need to wrap window.setTimeout and window.setInterval manually?

[blois, 2013-10-13 17:35:54]

On 2013/10/12 12:45:14, floitsch wrote:
> Thanks.
> LGTM (but I'm not familiar enough with the code, so wait for Emily).
> 
> Do we also need to wrap window.setTimeout and window.setInterval manually?

setTimeout and setInterval are supposed to be gone- we removed them a while
back, but they came back when Chrome moved them from Window to WindowTimers. See
bug 14041.

[Emily Fortuna, 2013-10-14 17:30:38]

minor quibble, then lgtm.

https://codereview.chromium.org/27082002/diff/3001/tools/dom/templates/html/d...
File tools/dom/templates/html/dart2js/html_dart2js.darttemplate (right):

https://codereview.chromium.org/27082002/diff/3001/tools/dom/templates/html/d...
tools/dom/templates/html/dart2js/html_dart2js.darttemplate:151:
_wrapZone(callback) {
feels a little suboptimal to put the identical code in both templates. Perhaps
put it in the top level in the impl_Window.dart file? All the other functions in
this file seem to have specific dart2js implementations.

[blois, 2013-10-14 19:48:49]

https://codereview.chromium.org/27082002/diff/3001/tools/dom/templates/html/d...
File tools/dom/templates/html/dart2js/html_dart2js.darttemplate (right):

https://codereview.chromium.org/27082002/diff/3001/tools/dom/templates/html/d...
tools/dom/templates/html/dart2js/html_dart2js.darttemplate:151:
_wrapZone(callback) {
On 2013/10/14 17:30:39, Emily Fortuna wrote:
> feels a little suboptimal to put the identical code in both templates. Perhaps
> put it in the top level in the impl_Window.dart file? All the other functions
in
> this file seem to have specific dart2js implementations.

Done.

[blois, 2013-10-14 19:49:29]

Committed patchset #3 manually as r28607 (presubmit successful).