- Add the ability to pass the command line options as an argument to main.

- Add the ability to pass the command line options as an argument to main.

R=asiva@google.com, floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28829

[floitsch, 2013-10-17 09:39:50]

LGTM.
I'm guessing that there could be false positives for main not taking the right
arguments (calling "main" in a different library with the wrong number of
arguments).
In theory that could lead to double execution if the actual main takes 0 or 1
argument.
As short-term solution that's ok, though.

[Anders Johnsen, 2013-10-17 09:52:29]

DBC

https://codereview.chromium.org/27073005/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/27073005/diff/1/runtime/bin/main.cc#newcode371
runtime/bin/main.cc:371: DartUtils::NewString(options->GetArgument(i));
Unintentional change?

https://codereview.chromium.org/27073005/diff/1/tests/corelib/main_test.dart
File tests/corelib/main_test.dart (right):

https://codereview.chromium.org/27073005/diff/1/tests/corelib/main_test.dart#...
tests/corelib/main_test.dart:8: main(List<String> args) {
Will this pass on dart2js/analyzer?

[siva, 2013-10-17 17:06:06]

lgtm

[Ivan Posva, 2013-10-17 21:38:48]

On 2013/10/17 09:39:50, floitsch wrote:
> LGTM.
> I'm guessing that there could be false positives for main not taking the right
> arguments (calling "main" in a different library with the wrong number of
> arguments).
> In theory that could lead to double execution if the actual main takes 0 or 1
> argument.
> As short-term solution that's ok, though.

To create a "fake" error object with exactly this string you would need to be in
C code. Regular Dart code would be hard-pressed to generate this.

-Ivan

[Ivan Posva, 2013-10-17 21:39:02]

https://codereview.chromium.org/27073005/diff/1/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://codereview.chromium.org/27073005/diff/1/runtime/bin/main.cc#newcode371
runtime/bin/main.cc:371: DartUtils::NewString(options->GetArgument(i));
On 2013/10/17 09:52:30, Anders Johnsen wrote:
> Unintentional change?

Indentation messup. Thanks!

https://codereview.chromium.org/27073005/diff/1/tests/corelib/main_test.dart
File tests/corelib/main_test.dart (right):

https://codereview.chromium.org/27073005/diff/1/tests/corelib/main_test.dart#...
tests/corelib/main_test.dart:8: main(List<String> args) {
On 2013/10/17 09:52:30, Anders Johnsen wrote:
> Will this pass on dart2js/analyzer?

Probably not. Still need to adjust the status file. But I wanted to make sure
this is what we agreed on.

[Ivan Posva, 2013-10-17 21:59:51]

Committed patchset #3 manually as r28829 (presubmit successful).