Issue 270703005: Fix source_update_test on Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 270703005: Fix source_update_test on Chrome. (Closed)

Created:
6 years, 7 months ago by ahe

Modified:
6 years, 7 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, lukechurch, Johnni Winther

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix source_update_test on Chrome. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=35896

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -2 lines)			Patch
M	dart/site/try/src/interaction_manager.dart	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	dart/site/try/src/selection.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	dart/site/try/src/shadow_root.dart	View	2 chunks	+13 lines, -0 lines	1 comment	Download
M	dart/tests/try/try.status	View	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

https://codereview.chromium.org/270703005/diff/1/dart/site/try/src/shadow_root.dart File dart/site/try/src/shadow_root.dart (right): https://codereview.chromium.org/270703005/diff/1/dart/site/try/src/shadow_root.dart#newcode53 dart/site/try/src/shadow_root.dart:53: return '$buffer'; Firefox or htmlToText adds one too many ...

6 years, 7 months ago (2014-05-08 09:07:53 UTC) #1

ahe

6 years, 7 months ago (2014-05-08 10:21:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r35896 (presubmit successful).

Expand Messages | Collapse Messages