Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 270693005: Remove unused import in polymer, fix comment. (Closed)

Created:
6 years, 7 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 7 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove unused import in polymer, fix comment. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=35865

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M pkg/polymer/lib/polymer.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/polymer/lib/src/instance.dart View 1 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Siggi Cherem (dart-lang)
https://codereview.chromium.org/270693005/diff/1/pkg/polymer/lib/src/instance.dart File pkg/polymer/lib/src/instance.dart (left): https://codereview.chromium.org/270693005/diff/1/pkg/polymer/lib/src/instance.dart#oldcode629 pkg/polymer/lib/src/instance.dart:629: /// Bind a [property] in this object to a ...
6 years, 7 months ago (2014-05-07 17:24:38 UTC) #1
Jennifer Messerly
https://codereview.chromium.org/270693005/diff/1/pkg/polymer/lib/src/instance.dart File pkg/polymer/lib/src/instance.dart (left): https://codereview.chromium.org/270693005/diff/1/pkg/polymer/lib/src/instance.dart#oldcode636 pkg/polymer/lib/src/instance.dart:636: /// bindProperty(#myProperty, this, 'myModel.path.to.otherProp'); I fixed this code snippet ...
6 years, 7 months ago (2014-05-07 19:28:53 UTC) #2
Siggi Cherem (dart-lang)
thx https://codereview.chromium.org/270693005/diff/1/pkg/polymer/lib/src/instance.dart File pkg/polymer/lib/src/instance.dart (left): https://codereview.chromium.org/270693005/diff/1/pkg/polymer/lib/src/instance.dart#oldcode636 pkg/polymer/lib/src/instance.dart:636: /// bindProperty(#myProperty, this, 'myModel.path.to.otherProp'); On 2014/05/07 19:28:53, John ...
6 years, 7 months ago (2014-05-07 19:34:48 UTC) #3
Jennifer Messerly
lgtm
6 years, 7 months ago (2014-05-07 20:25:17 UTC) #4
Siggi Cherem (dart-lang)
6 years, 7 months ago (2014-05-07 20:25:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r35865 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698