Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 27069003: New mirror tests: basic types found in dart:core and member collections are immutable. (Closed)

Created:
7 years, 2 months ago by rmacnak
Modified:
7 years, 2 months ago
Reviewers:
ahe, gbracha
CC:
reviews_dartlang.org, zarah
Visibility:
Public.

Description

New mirror tests: basic types found in dart:core and member collections are immutable. R=ahe@google.com, gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=28591

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -0 lines) Patch
M tests/lib/lib.status View 3 chunks +4 lines, -0 lines 0 comments Download
A tests/lib/mirrors/basic_types_in_dart_core_test.dart View 1 chunk +51 lines, -0 lines 0 comments Download
A tests/lib/mirrors/immutable_collections_test.dart View 1 chunk +86 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmacnak
7 years, 2 months ago (2013-10-11 22:08:19 UTC) #1
gbracha
lgtm
7 years, 2 months ago (2013-10-11 22:18:14 UTC) #2
ahe
lgtm
7 years, 2 months ago (2013-10-14 12:26:06 UTC) #3
rmacnak
7 years, 2 months ago (2013-10-14 17:07:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r28591 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698