Issue 270573007: Issue 16314. Skip leading UTF-8 BOM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 270573007: Issue 16314. Skip leading UTF-8 BOM. (Closed)

Created:
6 years, 7 months ago by scheglov

Modified:
6 years, 7 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 16314. Skip leading UTF-8 BOM. R=brianwilkerson@google.com BUG= https://code.google.com/p/dart/issues/detail?id=16314 Committed: https://code.google.com/p/dart/source/detail?r=35867

Patch Set 1 #

Total comments: 1

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -4 lines)			Patch
	M	editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/source/FileBasedSource.java	View		6 chunks	+29 lines, -2 lines	1 comment	Download
	M	tests/language/language_analyzer.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/270573007/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/source/FileBasedSource.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/source/FileBasedSource.java (right): https://codereview.chromium.org/270573007/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/source/FileBasedSource.java#newcode328 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/source/FileBasedSource.java:328: // re-open scream "scream" --> "stream"

6 years, 7 months ago (2014-05-07 20:26:56 UTC) #2

scheglov

6 years, 7 months ago (2014-05-07 20:35:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r35867 (presubmit successful).

Expand Messages | Collapse Messages