Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 27054002: Add unit tests to cover stack inspect in the presence of closure calls (Closed)

Created:
7 years, 2 months ago by turnidge
Modified:
7 years, 2 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add unit tests to cover stack inspect in the presence of closure calls for both optimized and non-optimized code. Fix an assert which was broken. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=28538

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -6 lines) Patch
M runtime/vm/debugger_api_impl_test.cc View 1 3 chunks +99 lines, -4 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
turnidge
Hi Ivan, This is just a new test for the upcoming work on contexts plus ...
7 years, 2 months ago (2013-10-11 17:26:57 UTC) #1
Ivan Posva
LGTM -ip
7 years, 2 months ago (2013-10-11 18:13:53 UTC) #2
turnidge
7 years, 2 months ago (2013-10-11 18:15:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r28538 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698