Issue 270363004: Fix end_to_end_test to not hang in CSP mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 270363004: Fix end_to_end_test to not hang in CSP mode. (Closed)

Created:
6 years, 7 months ago by ahe

Modified:
6 years, 7 months ago

Reviewers:
ricow1, kasperl

CC:
reviews_dartlang.org, lukechurch, Johnni Winther

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix end_to_end_test to not hang in CSP mode. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=35883

Patch Set 2 : Address Rico's comments #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -17 lines)			Patch
	M	dart/tests/try/end_to_end_test.dart	View	1	5 chunks	+30 lines, -16 lines	0 comments	Download
	M	dart/tests/try/try.status	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ricow1

lgtm https://codereview.chromium.org/270363004/diff/1/dart/tests/try/end_to_end_test.dart File dart/tests/try/end_to_end_test.dart (right): https://codereview.chromium.org/270363004/diff/1/dart/tests/try/end_to_end_test.dart#newcode61 dart/tests/try/end_to_end_test.dart:61: // Note: we have two options, use "iframe.contentWindow.onerror ...

6 years, 7 months ago (2014-05-08 05:33:09 UTC) #2

ahe

6 years, 7 months ago (2014-05-08 07:22:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r35883 (presubmit successful).

Expand Messages | Collapse Messages

Issue 270363004: Fix end_to_end_test to not hang in CSP mode. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address Rico's comments #

Messages