Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Issue 27020002: VM: Fix performance regression introduced by r28408. (Closed)

Created:
7 years, 2 months ago by Florian Schneider
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

VM: Fix performance regression introduced by r28408. Change the AST for static consts so that they don't end up translated as calls, and so that we don't rely on the inliner to fold them away). Instead I generate a LoadStatic AST node that will be constant folded in the flow graph builder. BUG=https://code.google.com/p/dart/issues/detail?id=13954 Committed: https://code.google.com/p/dart/source/detail?r=28521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M runtime/vm/flow_graph_builder.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
7 years, 2 months ago (2013-10-11 12:56:28 UTC) #1
Kevin Millikin (Google)
lgtm
7 years, 2 months ago (2013-10-11 15:04:18 UTC) #2
hausner
7 years, 2 months ago (2013-10-11 15:46:05 UTC) #3
Thank you!

Powered by Google App Engine
This is Rietveld 408576698