Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 27019003: Update check for cyclic typedefs. (Closed)

Created:
7 years, 2 months ago by Johnni Winther
Modified:
7 years, 2 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update status #

Patch Set 3 : Add positive test #

Total comments: 1

Patch Set 4 : Rebased #

Patch Set 5 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -25 lines) Patch
M sdk/lib/_internal/compiler/implementation/dart_types.dart View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 2 3 4 2 chunks +10 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 2 3 4 5 chunks +10 lines, -12 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/warnings.dart View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M tests/language/cyclic_typedef_test.dart View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 2 3 2 chunks +12 lines, -7 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
7 years, 2 months ago (2013-10-11 13:07:59 UTC) #1
karlklose
LGTM. https://codereview.chromium.org/27019003/diff/7001/sdk/lib/_internal/compiler/implementation/elements/modelx.dart File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right): https://codereview.chromium.org/27019003/diff/7001/sdk/lib/_internal/compiler/implementation/elements/modelx.dart#newcode1001 sdk/lib/_internal/compiler/implementation/elements/modelx.dart:1001: bool cyclicCheck = false; How about 'hasBeenCheckedForCycles'?
7 years, 2 months ago (2013-10-16 14:00:57 UTC) #2
Johnni Winther
7 years, 2 months ago (2013-10-17 07:06:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #5 manually as r28786 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698