Issue 27008003: Handle clash of prefix/non-prefix imports.

Issue 27008003: Handle clash of prefix/non-prefix imports. (Closed)

Created:
7 years, 2 months ago by Johnni Winther

Modified:
7 years, 2 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Handle clash of prefix/non-prefix imports. BUG=http://dartbug.com/5712 R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=28514

Patch Set 3 : Rebased + updated cf. comments. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+134 lines, -97 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/modelx.dart	View	1 2	6 chunks	+86 lines, -63 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/library_loader.dart	View		1 chunk	+9 lines, -27 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View		1 chunk	+15 lines, -1 line	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
A +	tests/language/hidden_import_lib.dart	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
A	tests/language/hidden_import_test.dart	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/27008003/diff/3001/sdk/lib/_internal/compiler/implementation/elements/modelx.dart File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right): https://codereview.chromium.org/27008003/diff/3001/sdk/lib/_internal/compiler/implementation/elements/modelx.dart#newcode655 sdk/lib/_internal/compiler/implementation/elements/modelx.dart:655: Element element, Import import, DiagnosticListener listener) { Use ...

7 years, 2 months ago (2013-10-11 11:51:48 UTC) #2

Johnni Winther

https://codereview.chromium.org/27008003/diff/3001/sdk/lib/_internal/compiler/implementation/elements/modelx.dart File sdk/lib/_internal/compiler/implementation/elements/modelx.dart (right): https://codereview.chromium.org/27008003/diff/3001/sdk/lib/_internal/compiler/implementation/elements/modelx.dart#newcode655 sdk/lib/_internal/compiler/implementation/elements/modelx.dart:655: Element element, Import import, DiagnosticListener listener) { On 2013/10/11 ...

7 years, 2 months ago (2013-10-11 12:30:30 UTC) #3

Johnni Winther

7 years, 2 months ago (2013-10-11 12:33:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r28514 (presubmit successful).

Expand Messages | Collapse Messages