Issue 27006003: Cleanups, refactoring in anticipation of new string interpolation nodes. Removed unnecessary code.

Issue 27006003: Cleanups, refactoring in anticipation of new string interpolation nodes. Removed unnecessary code. (Closed)

Created:
7 years, 2 months ago by srdjan

Modified:
7 years, 2 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Cleanups, refactoring in anticipation of new string interpolation nodes. Removed unnecessary code. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=28619

Patch Set 2 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -156 lines)			Patch
M	runtime/vm/flow_graph_builder.cc	View		5 chunks	+4 lines, -11 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View		3 chunks	+0 lines, -102 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/object.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
M	runtime/vm/parser.cc	View	1	15 chunks	+22 lines, -41 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hausner

LGTM. Yay for removing more lines than adding new ones. https://codereview.chromium.org/27006003/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/27006003/diff/1/runtime/vm/object.cc#newcode7775 ...

7 years, 2 months ago (2013-10-14 23:11:14 UTC) #2

srdjan

https://codereview.chromium.org/27006003/diff/1/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/27006003/diff/1/runtime/vm/object.cc#newcode7775 runtime/vm/object.cc:7775: // Private identifiers are mangled on a per script ...

7 years, 2 months ago (2013-10-14 23:19:42 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r28619.

Expand Messages | Collapse Messages