Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Issue 26993002: Add factory-method for scheduleMicrotask, as well as a (failing) test. (Closed)

Created:
7 years, 2 months ago by Anders Johnsen
Modified:
7 years, 2 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add factory-method for scheduleMicrotask, as well as a (failing) test. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=28653

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove 'factory'. #

Patch Set 3 : Rename files and method. #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -104 lines) Patch
M runtime/lib/async_sources.gypi View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/event_loop_patch.dart View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
A runtime/lib/schedule_microtask_patch.dart View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
M sdk/lib/_internal/lib/async_patch.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/async.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/async_sources.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
D sdk/lib/async/event_loop.dart View 1 2 1 chunk +0 lines, -79 lines 0 comments Download
A + sdk/lib/async/schedule_microtask.dart View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M tests/lib/async/schedule_microtask_test.dart View 1 1 chunk +91 lines, -6 lines 0 comments Download
M tests/lib/lib.status View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Anders Johnsen
7 years, 2 months ago (2013-10-11 08:41:42 UTC) #1
floitsch
LGTM although I'm not sure of the status-line. https://codereview.chromium.org/26993002/diff/1/runtime/lib/event_loop_patch.dart File runtime/lib/event_loop_patch.dart (right): https://codereview.chromium.org/26993002/diff/1/runtime/lib/event_loop_patch.dart#newcode19 runtime/lib/event_loop_patch.dart:19: class ...
7 years, 2 months ago (2013-10-11 09:35:37 UTC) #2
Anders Johnsen
Please comment on the naming. Currently we call it EnqueueImmediate. Do we want to call ...
7 years, 2 months ago (2013-10-14 10:15:10 UTC) #3
Anders Johnsen
Oh, and the status file is just to say that we can compile it, but ...
7 years, 2 months ago (2013-10-14 10:15:52 UTC) #4
Anders Johnsen
PTAL, did some renaming of files and methods.
7 years, 2 months ago (2013-10-15 16:03:46 UTC) #5
floitsch
Still LGTM. https://codereview.chromium.org/26993002/diff/10001/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/26993002/diff/10001/tests/lib/lib.status#newcode229 tests/lib/lib.status:229: async/schedule_microtask_test: Fail # Issue 9001 Issue 9001 ...
7 years, 2 months ago (2013-10-15 16:10:24 UTC) #6
Anders Johnsen
https://codereview.chromium.org/26993002/diff/10001/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/26993002/diff/10001/tests/lib/lib.status#newcode229 tests/lib/lib.status:229: async/schedule_microtask_test: Fail # Issue 9001 On 2013/10/15 16:10:25, floitsch ...
7 years, 2 months ago (2013-10-15 16:21:13 UTC) #7
Anders Johnsen
7 years, 2 months ago (2013-10-15 16:22:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 manually as r28653 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698