Emit a compile-time error when using doubles as switch case expressions.

Emit a compile-time error when using doubles as switch case expressions.

R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28637

[Johnni Winther, 2013-10-15 11:47:44]

lgtm

https://codereview.chromium.org/26978004/diff/6001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/typechecker.dart (right):

https://codereview.chromium.org/26978004/diff/6001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/typechecker.dart:1199: message:
"Expected interface type"));
Why can't we see other types here? What about these?

switch (e) {
case null:
case m(): // void m() {}
}

[karlklose, 2013-10-15 11:59:44]

On 2013/10/15 11:47:44, Johnni Winther wrote:
> lgtm
> 
>
https://codereview.chromium.org/26978004/diff/6001/sdk/lib/_internal/compiler...
> File sdk/lib/_internal/compiler/implementation/typechecker.dart (right):
> 
>
https://codereview.chromium.org/26978004/diff/6001/sdk/lib/_internal/compiler...
> sdk/lib/_internal/compiler/implementation/typechecker.dart:1199: message:
> "Expected interface type"));
> Why can't we see other types here? What about these?
> 
> switch (e) {
> case null:
> case m(): // void m() {}
> }

null gets type dynamic (which is an interface type) and all other cases are not
compile-time constants, so the resolver aborts compilation.

[karlklose, 2013-10-15 12:03:59]

Committed patchset #3 manually as r28637 (presubmit successful).