Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 26976002: Optimize some collection operations. (Closed)

Created:
7 years, 2 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 2 months ago
Reviewers:
floitsch, srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Optimize some collection operations. Extracted from EfficientLength CL. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=28509

Patch Set 1 #

Patch Set 2 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M runtime/lib/array.dart View 1 1 chunk +10 lines, -8 lines 0 comments Download
M sdk/lib/collection/hash_set.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
7 years, 2 months ago (2013-10-11 05:52:10 UTC) #1
floitsch
LGTM.
7 years, 2 months ago (2013-10-11 09:37:51 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #2 manually as r28509 (presubmit successful).
7 years, 2 months ago (2013-10-11 11:40:03 UTC) #3
srdjan
7 years, 2 months ago (2013-10-14 21:40:46 UTC) #4
Message was sent while issue was closed.
Please add someone from the VM team to the reviewer list when changing runtime
libraries. Thanks.

Powered by Google App Engine
This is Rietveld 408576698