Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 26971005: Tighter native type annotations for some elements returning Lists (Closed)

Created:
7 years, 2 months ago by sra1
Modified:
7 years, 2 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Tighter native type annotations for some elements returning Lists We need to be more careful with type annotations on native elements now that some classes implement List<dynamic>. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=28626

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M sdk/lib/_internal/lib/js_helper.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M sdk/lib/_internal/lib/js_rti.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 3 chunks +6 lines, -0 lines 0 comments Download
M tools/dom/scripts/dartmetadata.py View 1 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sra1
7 years, 2 months ago (2013-10-14 23:49:23 UTC) #1
blois
lgtm
7 years, 2 months ago (2013-10-15 01:01:18 UTC) #2
sra1
7 years, 2 months ago (2013-10-15 01:45:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r28626 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698