Issue 26969005: Output character literals rather than ints in create_resources.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26969005: Output character literals rather than ints in create_resources.py (Closed)

Created:
7 years, 2 months ago by Chris Bracken

Modified:
7 years, 2 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Output character literals rather than ints in create_resources.py Fixes the following class of errors under gcc 4.8: out/ReleaseX64/obj/gen/resources_gen.cc:3074:1: error: narrowing conversion of ‘137’ from ‘int’ to ‘const char’ inside { } is ill-formed in C++11 [-Werror=narrowing] BUG= R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=28752

Patch Set 1 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/tools/create_resources.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Chris Bracken

7 years, 2 months ago (2013-10-16 21:32:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r28752 (presubmit successful).

Expand Messages | Collapse Messages