Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 269623004: Remove the getaddrinfo mutex, but put mutex around winsock initialization. (Closed)

Created:
6 years, 7 months ago by Anders Johnsen
Modified:
6 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Remove the getaddrinfo mutex, but put mutex around winsock initialization. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=35617

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M runtime/bin/socket_win.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
I ran this overnight, looping all *secure* tests, with no failures.
6 years, 7 months ago (2014-05-01 06:33:58 UTC) #1
Søren Gjesse
LGTM!
6 years, 7 months ago (2014-05-01 07:20:42 UTC) #2
Anders Johnsen
6 years, 7 months ago (2014-05-01 08:33:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r35617 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698