Issue 26917002: Convert keys in dataSet to camelCase instead of dasherized.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26917002: Convert keys in dataSet to camelCase instead of dasherized. (Closed)

Created:
7 years, 2 months ago by Emily Fortuna

Modified:
7 years, 2 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Convert keys in dataSet to camelCase instead of dasherized. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=28482

Patch Set 1 #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -6 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	1 chunk	+31 lines, -2 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	1 chunk	+31 lines, -2 lines	0 comments	Download
M	tests/html/htmlelement_test.dart	View	1 chunk	+19 lines, -0 lines	1 comment	Download
M	tools/dom/src/AttributeMap.dart	View	1 chunk	+31 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Fix for https://code.google.com/p/dart/issues/detail?id=13008

7 years, 2 months ago (2013-10-10 20:44:41 UTC) #1

blois

lgtm https://codereview.chromium.org/26917002/diff/1/tests/html/htmlelement_test.dart File tests/html/htmlelement_test.dart (right): https://codereview.chromium.org/26917002/diff/1/tests/html/htmlelement_test.dart#newcode107 tests/html/htmlelement_test.dart:107: class UnhelpfulSanitizer implements NodeTreeSanitizer { import utils.dart and ...

7 years, 2 months ago (2013-10-10 21:13:38 UTC) #2

Emily Fortuna

7 years, 2 months ago (2013-10-10 21:42:19 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r28482 (presubmit successful).

Expand Messages | Collapse Messages