Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 26893008: Adding HttpRequest.responseHeaders (Closed)

Created:
7 years, 2 months ago by blois
Modified:
7 years, 2 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Adding HttpRequest.responseHeaders The code is mostly from Closure's getResponseHeaders function, with modifications to make the keys case-insensitive (following jQuery's model). BUG=13584 R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=28812

Patch Set 1 #

Patch Set 2 : Tightening up some error edge cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -9 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 3 chunks +39 lines, -3 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +39 lines, -3 lines 0 comments Download
M tests/html/xhr_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_XMLHttpRequest.darttemplate View 1 3 chunks +39 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 2 months ago (2013-10-17 17:35:10 UTC) #1
Emily Fortuna
lgtm
7 years, 2 months ago (2013-10-17 17:37:42 UTC) #2
blois
7 years, 2 months ago (2013-10-17 18:11:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r28812 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698