Issue 26888005: Disallow extending a malformed type (issue 13940).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26888005: Disallow extending a malformed type (issue 13940). (Closed)

Created:
7 years, 2 months ago by regis

Modified:
7 years, 2 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Disallow extending a malformed type (issue 13940). Add language test and update dart2js status (issue 13994 filed). R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=28488

Patch Set 2 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -1 line)			Patch
M	runtime/vm/object.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	tests/language/language_dart2js.status	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/language/malformed_inheritance_test.dart	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rmacnak

LGTM https://codereview.chromium.org/26888005/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/26888005/diff/1/runtime/vm/parser.cc#newcode3809 runtime/vm/parser.cc:3809: // The string 'dynamic' is not resolved yet ...

7 years, 2 months ago (2013-10-10 23:26:37 UTC) #2

regis

Thanks! https://codereview.chromium.org/26888005/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://codereview.chromium.org/26888005/diff/1/runtime/vm/parser.cc#newcode3809 runtime/vm/parser.cc:3809: // The string 'dynamic' is not resolved yet ...

7 years, 2 months ago (2013-10-10 23:29:54 UTC) #3

regis

7 years, 2 months ago (2013-10-10 23:30:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r28488 (presubmit successful).

Expand Messages | Collapse Messages

Issue 26888005: Disallow extending a malformed type (issue 13940). (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages