Issue 268853003: Fix library snapshotting breakage with native entry symbol resolver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 268853003: Fix library snapshotting breakage with native entry symbol resolver (Closed)

Created:
6 years, 7 months ago by Cutch

Modified:
6 years, 7 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix library snapshotting breakage with native entry symbol resolver. - Write out a NULL for the libraries Dart_NativeEntrySymbol. - Read in the NULL for the libraries Dart_NativeEntrySymbol. - Set the libraries Dart_NativeEntrySymbol to NULL. - Use reusable handles. R=turnidge@google.com Committed: https://code.google.com/p/dart/source/detail?r=35812

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -6 lines)			Patch
M	runtime/vm/isolate.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/native_entry.cc	View		2 chunks	+9 lines, -6 lines	0 comments	Download
M	runtime/vm/raw_object_snapshot.cc	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/reusable_handles.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	tests/standalone/issue14236_test.dart	View	1	Binary file		0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

turnidge

lgtm w/ comment. This change will probably make tests/standalone/issue14236_test.dart fail -- it is a test ...

6 years, 7 months ago (2014-05-06 18:09:03 UTC) #2

Cutch

6 years, 7 months ago (2014-05-06 18:09:55 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r35812 (presubmit successful).

Expand Messages | Collapse Messages