Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 268673018: Add deprecated WebSocket constructor. (Closed)

Created:
6 years, 7 months ago by Anders Johnsen
Modified:
6 years, 7 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add deprecated WebSocket constructor. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=35791

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M sdk/lib/io/websocket.dart View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Anders Johnsen
6 years, 7 months ago (2014-05-06 06:38:54 UTC) #1
Søren Gjesse
https://codereview.chromium.org/268673018/diff/1/sdk/lib/io/websocket.dart File sdk/lib/io/websocket.dart (right): https://codereview.chromium.org/268673018/diff/1/sdk/lib/io/websocket.dart#newcode137 sdk/lib/io/websocket.dart:137: ' `implements` instead of `extends`.') Maybe change 'Consider using ...
6 years, 7 months ago (2014-05-06 08:13:03 UTC) #2
Anders Johnsen
PTAL https://codereview.chromium.org/268673018/diff/1/sdk/lib/io/websocket.dart File sdk/lib/io/websocket.dart (right): https://codereview.chromium.org/268673018/diff/1/sdk/lib/io/websocket.dart#newcode137 sdk/lib/io/websocket.dart:137: ' `implements` instead of `extends`.') On 2014/05/06 08:13:04, ...
6 years, 7 months ago (2014-05-06 08:17:04 UTC) #3
Søren Gjesse
lgtm
6 years, 7 months ago (2014-05-06 08:56:13 UTC) #4
Anders Johnsen
6 years, 7 months ago (2014-05-06 08:56:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r35791 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698