Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Issue 26866005: Allow malbounded literal types (fix issue 13952). (Closed)

Created:
7 years, 2 months ago by regis
Modified:
7 years, 2 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Allow malbounded literal types (fix issue 13952). R=rmacnak@google.com Committed: https://code.google.com/p/dart/source/detail?r=28474

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/parser.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
regis
7 years, 2 months ago (2013-10-10 18:59:19 UTC) #1
rmacnak
LGTM The new mirror tests with type bounds still crash, but now it is asserts ...
7 years, 2 months ago (2013-10-10 20:20:34 UTC) #2
regis
7 years, 2 months ago (2013-10-10 20:45:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28474 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698