Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 26863008: Fix observe package to work with new barback logger. (Closed)

Created:
7 years, 2 months ago by Bob Nystrom
Modified:
7 years, 2 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix observe package to work with new barback logger. BUG= R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=28492

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M pkg/observe/lib/transform.dart View 6 chunks +6 lines, -6 lines 0 comments Download
M pkg/observe/test/transform_test.dart View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Bob Nystrom
7 years, 2 months ago (2013-10-11 00:18:24 UTC) #1
Siggi Cherem (dart-lang)
lgtm!
7 years, 2 months ago (2013-10-11 00:19:33 UTC) #2
Bob Nystrom
7 years, 2 months ago (2013-10-11 00:21:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28492 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698