[html5lib] implement querySelector/querySelectorAll

[html5lib] implement querySelector/querySelectorAll

BUG= https://code.google.com/p/dart/issues/detail?id=18508

* tests from https://github.com/w3c/web-platform-tests/tree/master/selectors-api, kept as close to original as I could.

* src/query_selector.dart is most interesting file. It implements enough of selectors to pass the basic web platform tests. Ironically, it was the easiest part of this CL...

* many fixes to csslib. Almost all of the selector tests were skipped (https://github.com/dart-lang/csslib-test-suite/blob/master/suite/selectors3/selectors3_test.dart) and there was a lot of things broken: unicode, escaping, incorrectly treating ident-tokens as units, probably more that I am forgetting :). Fixed as much as I could without doing major surgery.

* a bunch of fixes to the htm5lib DOM to bring it closer in alignment with dom.spec.whatwg.org and dart:html. The driving force was to minimize the changes needed on the W3C tests.

Note: haven't updated things that depend on html5lib like Polymer yet.

R=sigmund@google.com

Committed: https://code.google.com/p/dart/source/detail?r=35941

[Siggi Cherem (dart-lang), 2014-05-02 17:46:10]

lgtm

https://codereview.chromium.org/268623002/diff/60001/pkg/third_party/html5lib...
File pkg/third_party/html5lib/lib/src/css_class_set.dart (right):

https://codereview.chromium.org/268623002/diff/60001/pkg/third_party/html5lib...
pkg/third_party/html5lib/lib/src/css_class_set.dart:113: abstract class
CssClassSetImpl implements CssClassSet {
was this and below copied from dart:html? should we have a TODO about merging
them back one day?

https://codereview.chromium.org/268623002/diff/60001/pkg/third_party/html5lib...
File pkg/third_party/html5lib/pubspec.yaml (right):

https://codereview.chromium.org/268623002/diff/60001/pkg/third_party/html5lib...
pkg/third_party/html5lib/pubspec.yaml:16: csslib: { path:
/mnt/code/dart/dart/pkg/csslib }
delete before submitting

https://codereview.chromium.org/268623002/diff/60001/pkg/third_party/html5lib...
File pkg/third_party/html5lib/test/selectors/level1_baseline_test.dart (right):

https://codereview.chromium.org/268623002/diff/60001/pkg/third_party/html5lib...
pkg/third_party/html5lib/test/selectors/level1_baseline_test.dart:104:
runValidSelectorTest("Detached Element", detached, validSelectors, testType,
docType);
80 col? Or does the same note you made in the next file applies here too?

https://codereview.chromium.org/268623002/diff/60001/pkg/third_party/html5lib...
File pkg/third_party/html5lib/test/selectors/level1_lib.dart (right):

https://codereview.chromium.org/268623002/diff/60001/pkg/third_party/html5lib...
pkg/third_party/html5lib/test/selectors/level1_lib.dart:5: /// as [test]
arguments having a different order, long lines, etc.
makes sense, same for indentation? or could we fixed that below?

[Jennifer Messerly, 2014-05-06 20:42:59]

hey Terry, do you mind if I submit this after fixing Siggi's comments? I'm happy
to follow up CL's with any additional changes, if that works for you.

[Jennifer Messerly, 2014-05-08 21:15:40]

thanks Siggi! comments addressed

https://codereview.chromium.org/268623002/diff/60001/pkg/third_party/html5lib...
File pkg/third_party/html5lib/lib/src/css_class_set.dart (right):

https://codereview.chromium.org/268623002/diff/60001/pkg/third_party/html5lib...
pkg/third_party/html5lib/lib/src/css_class_set.dart:113: abstract class
CssClassSetImpl implements CssClassSet {
On 2014/05/02 17:46:10, Siggi Cherem (dart-lang) wrote:
> was this and below copied from dart:html? should we have a TODO about merging
> them back one day?

yup. Done.

https://codereview.chromium.org/268623002/diff/60001/pkg/third_party/html5lib...
File pkg/third_party/html5lib/pubspec.yaml (right):

https://codereview.chromium.org/268623002/diff/60001/pkg/third_party/html5lib...
pkg/third_party/html5lib/pubspec.yaml:16: csslib: { path:
/mnt/code/dart/dart/pkg/csslib }
On 2014/05/02 17:46:10, Siggi Cherem (dart-lang) wrote:
> delete before submitting

Done.

https://codereview.chromium.org/268623002/diff/60001/pkg/third_party/html5lib...
File pkg/third_party/html5lib/test/selectors/level1_baseline_test.dart (right):

https://codereview.chromium.org/268623002/diff/60001/pkg/third_party/html5lib...
pkg/third_party/html5lib/test/selectors/level1_baseline_test.dart:104:
runValidSelectorTest("Detached Element", detached, validSelectors, testType,
docType);
On 2014/05/02 17:46:10, Siggi Cherem (dart-lang) wrote:
> 80 col? Or does the same note you made in the next file applies here too?

yeah, it's another ported test file :)

https://codereview.chromium.org/268623002/diff/60001/pkg/third_party/html5lib...
File pkg/third_party/html5lib/test/selectors/level1_lib.dart (right):

https://codereview.chromium.org/268623002/diff/60001/pkg/third_party/html5lib...
pkg/third_party/html5lib/test/selectors/level1_lib.dart:5: /// as [test]
arguments having a different order, long lines, etc.
On 2014/05/02 17:46:10, Siggi Cherem (dart-lang) wrote:
> makes sense, same for indentation? or could we fixed that below?

yeah, they're using tabs. Actually took me a while to notice, since all my tools
are set up to render it as 2 spaces :-). Can fix that super easy though. Done!

[Jennifer Messerly, 2014-05-08 21:41:18]

Committed patchset #4 manually as r35941 (presubmit successful).