Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 26832002: Add Set.lookup method to get the instance in the set. (Closed)

Created:
7 years, 2 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 2 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, kasperl
Visibility:
Public.

Description

Add Set.lookup method to get the instance in the set. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=28499

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -3 lines) Patch
M pkg/unmodifiable_collection/lib/unmodifiable_collection.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/lib/collection_patch.dart View 3 chunks +21 lines, -0 lines 0 comments Download
M sdk/lib/_internal/lib/collection_patch.dart View 4 chunks +35 lines, -0 lines 0 comments Download
M sdk/lib/core/set.dart View 1 chunk +8 lines, -0 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/html/html_common/css_class_set.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/corelib/hash_set_test.dart View 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years, 2 months ago (2013-10-10 12:30:30 UTC) #1
floitsch
LGTM.
7 years, 2 months ago (2013-10-10 12:50:14 UTC) #2
Lasse Reichstein Nielsen
7 years, 2 months ago (2013-10-11 07:16:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r28499 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698