Issue 268313002: [dart:html] rename register to registerElement per spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 268313002: [dart:html] rename register to registerElement per spec (Closed)

Created:
6 years, 7 months ago by Jennifer Messerly

Modified:
6 years, 7 months ago

Reviewers:
Jacob

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

[dart:html] rename register to registerElement per spec BUG= https://code.google.com/p/dart/issues/detail?id=18621 R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=35829

Patch Set 1 #

Patch Set 2 : rebase #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -75 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	5 chunks	+18 lines, -6 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	5 chunks	+18 lines, -6 lines	0 comments	Download
M	tests/html/custom/attribute_changed_callback_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/html/custom/constructor_calls_created_synchronously_test.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tests/html/custom/created_callback_test.dart	View	7 chunks	+12 lines, -10 lines	0 comments	Download
M	tests/html/custom/document_register_basic_test.dart	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	tests/html/custom/document_register_type_extensions_test.dart	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	tests/html/custom/element_upgrade_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/custom/entered_left_view_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/html/custom/js_custom_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/html/custom/mirrors_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/html/custom/regress_194523002_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/html/custom/template_wrappers_test.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/html/custom_elements_test.dart	View	8 chunks	+12 lines, -12 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Document.darttemplate	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate	View	3 chunks	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

6 years, 7 months ago (2014-05-06 20:41:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r35829 (presubmit successful).

Expand Messages | Collapse Messages