Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 26768005: Add mirror test for f-bounded mixin applications and generic mixins. (Closed)

Created:
7 years, 2 months ago by rmacnak
Modified:
7 years, 2 months ago
Reviewers:
regis, gbracha, ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add mirror tests for f-bounded mixin applications and generic mixins (not to be confused with mixin applications). R=ahe@google.com, gbracha@google.com, regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=28664

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -0 lines) Patch
M tests/lib/lib.status View 1 2 4 chunks +8 lines, -0 lines 0 comments Download
A tests/lib/mirrors/generic_f_bounded_mixin_application_test.dart View 1 2 1 chunk +115 lines, -0 lines 0 comments Download
A tests/lib/mirrors/generic_mixin_test.dart View 1 1 chunk +104 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rmacnak
7 years, 2 months ago (2013-10-14 23:56:04 UTC) #1
gbracha
lgtm with comment https://codereview.chromium.org/26768005/diff/3001/tests/lib/mirrors/generic_f_bounded_mixin_application_test.dart File tests/lib/mirrors/generic_f_bounded_mixin_application_test.dart (right): https://codereview.chromium.org/26768005/diff/3001/tests/lib/mirrors/generic_f_bounded_mixin_application_test.dart#newcode96 tests/lib/mirrors/generic_f_bounded_mixin_application_test.dart:96: typeParameters(serializerOfOrderedCollection, [#R]); This is a duplicate
7 years, 2 months ago (2013-10-15 00:28:24 UTC) #2
regis
LGTM If you wait for Matthias to submit his pending change, you'll be able to ...
7 years, 2 months ago (2013-10-15 00:31:18 UTC) #3
ahe
LGTM! https://codereview.chromium.org/26768005/diff/3001/tests/lib/mirrors/generic_f_bounded_mixin_application_test.dart File tests/lib/mirrors/generic_f_bounded_mixin_application_test.dart (right): https://codereview.chromium.org/26768005/diff/3001/tests/lib/mirrors/generic_f_bounded_mixin_application_test.dart#newcode41 tests/lib/mirrors/generic_f_bounded_mixin_application_test.dart:41: ClassMirror abstractOrderedCollectionDecl = reflectClass(AbstractOrderedCollection); Long line. More below. ...
7 years, 2 months ago (2013-10-15 06:56:42 UTC) #4
rmacnak
https://codereview.chromium.org/26768005/diff/3001/tests/lib/lib.status File tests/lib/lib.status (right): https://codereview.chromium.org/26768005/diff/3001/tests/lib/lib.status#newcode182 tests/lib/lib.status:182: mirrors/generic_mixin_test/02: RuntimeError On 2013/10/15 00:31:18, regis wrote: > No ...
7 years, 2 months ago (2013-10-15 17:22:39 UTC) #5
rmacnak
7 years, 2 months ago (2013-10-15 17:22:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r28664 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698