Make sure exports treat dart: libs specially just like imports.

Make sure exports treat dart: libs specially just like imports.

R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28540

[ahe, 2013-10-10 11:53:19]

https://codereview.chromium.org/26768004/diff/4001/docs/language/dartLangSpec...
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/26768004/diff/4001/docs/language/dartLangSpec...
docs/language/dartLangSpec.tex:5397: If a name $N$ is referenced by a library
$L$ and $N$ would be introduced into the exported namespace of $L$ by an export
from a library whose name begins with \code{dart:} and an export from a library
whose name does not begin with \code{dart:}:
Everything is good except that it is not clear to me what the name of a library
is.

In mirrors, the name of a library is what its "library" declaration says, so all
dart libraries, by convention are named "dart.something".

However, any user can declare a library named "dart.something". However, they
cannot change how we handle URLs, that is, a library whose URI starts with
"dart:".

So I suspect that something is a bit off here.

[gbracha, 2013-10-10 19:58:39]

On 2013/10/10 11:53:19, ahe wrote:
>
https://codereview.chromium.org/26768004/diff/4001/docs/language/dartLangSpec...
> File docs/language/dartLangSpec.tex (right):
> 
>
https://codereview.chromium.org/26768004/diff/4001/docs/language/dartLangSpec...
> docs/language/dartLangSpec.tex:5397: If a name $N$ is referenced by a library
> $L$ and $N$ would be introduced into the exported namespace of $L$ by an
export
> from a library whose name begins with \code{dart:} and an export from a
library
> whose name does not begin with \code{dart:}:
> Everything is good except that it is not clear to me what the name of a
library
> is.
> 
> In mirrors, the name of a library is what its "library" declaration says, so
all
> dart libraries, by convention are named "dart.something".
> 
> However, any user can declare a library named "dart.something". However, they
> cannot change how we handle URLs, that is, a library whose URI starts with
> "dart:".
> 
> So I suspect that something is a bit off here.

Yes. I'll change it to "URI begins with".

[gbracha, 2013-10-10 19:59:53]

PTAL

[ahe, 2013-10-11 05:21:03]

LGTM once you fix the two additional references to library name.

https://codereview.chromium.org/26768004/diff/10001/docs/language/dartLangSpe...
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/26768004/diff/10001/docs/language/dartLangSpe...
docs/language/dartLangSpec.tex:5295: If a name $N$ is referenced by a library
$L$ and $N$ would be introduced into the top level scope of $L$ by an import
from a library whose URI begins with \code{dart:} and an import from a library
whose name does not begin with \code{dart:}:
This sentence contains another use of "name" that should be changed to URI.

https://codereview.chromium.org/26768004/diff/10001/docs/language/dartLangSpe...
docs/language/dartLangSpec.tex:5397: If a name $N$ is referenced by a library
$L$ and $N$ would be introduced into the exported namespace of $L$ by an export
from a library whose URI begins with \code{dart:} and an export from a library
whose name does not begin with \code{dart:}:
Ditto.

[gbracha, 2013-10-11 19:13:09]

Committed patchset #3 manually as r28540 (presubmit successful).

[gbracha, 2013-10-11 19:13:42]

https://codereview.chromium.org/26768004/diff/10001/docs/language/dartLangSpe...
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/26768004/diff/10001/docs/language/dartLangSpe...
docs/language/dartLangSpec.tex:5295: If a name $N$ is referenced by a library
$L$ and $N$ would be introduced into the top level scope of $L$ by an import
from a library whose URI begins with \code{dart:} and an import from a library
whose name does not begin with \code{dart:}:
On 2013/10/11 05:21:03, ahe wrote:
> This sentence contains another use of "name" that should be changed to URI.

Done.

https://codereview.chromium.org/26768004/diff/10001/docs/language/dartLangSpe...
docs/language/dartLangSpec.tex:5397: If a name $N$ is referenced by a library
$L$ and $N$ would be introduced into the exported namespace of $L$ by an export
from a library whose URI begins with \code{dart:} and an export from a library
whose name does not begin with \code{dart:}:
On 2013/10/11 05:21:03, ahe wrote:
> Ditto.

Done.