Add test for using a type literal for a malbounded type. Crashes the VM in debug mode.

Add test for using a type literal for a malbounded type. Crashes the VM in debug mode.

R=gbracha@google.com, regis@google.com

Committed: https://code.google.com/p/dart/source/detail?r=28428

[gbracha, 2013-10-09 21:15:26]

lgtm with comment

https://codereview.chromium.org/26761002/diff/2001/tests/language/malbounded_...
File tests/language/malbounded_type_literal_test.dart (right):

https://codereview.chromium.org/26761002/diff/2001/tests/language/malbounded_...
tests/language/malbounded_type_literal_test.dart:13: Expect.isTrue(t is Type);
The test looks fine. The diff is weird though. It looks as though there was a
completely unrealted file of the same name?

[regis, 2013-10-09 21:17:33]

LGTM

https://codereview.chromium.org/26761002/diff/2001/tests/language/malbounded_...
File tests/language/malbounded_type_literal_test.dart (left):

https://codereview.chromium.org/26761002/diff/2001/tests/language/malbounded_...
tests/language/malbounded_type_literal_test.dart:11:
Expect.isFalse(Primitives.isJsshell);
Where is this coming from? Did you svn copy maybe? It's better to do a copy and
then a svn add, so that you do not preserve unrelated history.

[rmacnak, 2013-10-09 21:26:28]

On 2013/10/09 21:17:33, regis wrote:
> LGTM
> 
>
https://codereview.chromium.org/26761002/diff/2001/tests/language/malbounded_...
> File tests/language/malbounded_type_literal_test.dart (left):
> 
>
https://codereview.chromium.org/26761002/diff/2001/tests/language/malbounded_...
> tests/language/malbounded_type_literal_test.dart:11:
> Expect.isFalse(Primitives.isJsshell);
> Where is this coming from? Did you svn copy maybe? It's better to do a copy
and
> then a svn add, so that you do not preserve unrelated history.

Git discovers copies by looking for similarity rather than being explicitly
told. Since most of the test is the copyright notice, it is very similar to many
other small tests in the repository.

[regis, 2013-10-09 21:31:59]

On 2013/10/09 21:26:28, Ryan Macnak wrote:
> On 2013/10/09 21:17:33, regis wrote:
> > LGTM
> > 
> >
>
https://codereview.chromium.org/26761002/diff/2001/tests/language/malbounded_...
> > File tests/language/malbounded_type_literal_test.dart (left):
> > 
> >
>
https://codereview.chromium.org/26761002/diff/2001/tests/language/malbounded_...
> > tests/language/malbounded_type_literal_test.dart:11:
> > Expect.isFalse(Primitives.isJsshell);
> > Where is this coming from? Did you svn copy maybe? It's better to do a copy
> and
> > then a svn add, so that you do not preserve unrelated history.
> 
> Git discovers copies by looking for similarity rather than being explicitly
> told. Since most of the test is the copyright notice, it is very similar to
many
> other small tests in the repository.

This git behavior makes no sense to me. I'll stick with svn.

[rmacnak, 2013-10-09 23:09:35]

Committed patchset #3 manually as r28428 (presubmit successful).

[ahe, 2013-10-10 15:41:10]

LGTM!

https://codereview.chromium.org/26761002/diff/10001/tests/language/language.s...
File tests/language/language.status (right):

https://codereview.chromium.org/26761002/diff/10001/tests/language/language.s...
tests/language/language.status:33: malbounded_type_literal_test: Pass, Crash #
Issue 13952
This indicates that this is flaky. My understanding from the CL description is
that it always crashes in debug mode, in which case it should be:

[ $compiler == none && $mode == debug ]
malbounded_type_literal_test: Crash # Issue 13952